patternfly / patternfly/patternfly-react
Scrollable areas - add dynamic shadows based on scroll position
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- TypeScript
- Estrellas
- 862
- Forks
- 392
- Merge medio
- 4 d 8 h
- PR fusionados (30 d)
- 9
Descripción
From @jamestalton, I wanted to create an issue to track a request I've heard from James a few times. It would be super cool if PF was able to add shadows to scrollable regions dynamically. A good example we could currently work with is scrollable page sections. You designate a page section as .pf-m-overflow-scroll, and by default, it looks like any other page section. However, if its content is taller than the section, it will automatically add a scrollbar and the content becomes scrollable. PF could detected that there is overflow and added a shadow dynamically. Currently users can add shadows themselves by adding .pf-m-shadow-bottom (one for a top shadow, too) to the preceding page section, but that class adds a static shadow. If you add it because the section below has the potential to scroll, but doesn't scroll because there is no overflow content, the shadow appears unnecessarily.
Some questions:
-
Currently a user could wire this up themselves, but should PF provide this ability?
-
Would this be enabled for all scrollable regions? Sounds like that has the potential to create a lot of work to implement/maintain.
-
Is there any kind of performance cost?
-
Are there other cases for dynamic shadows - for example, adding a shadow only once you've scrolled a little bit? What's the LEO for that and does it come with performance costs?
Anything else you'd like to add @jamestalton?
Jira Issue: PF-1775
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con la demo overflow-scroll de las secciones de página desplazables enlazadas y revisa cómo se comportan actualmente .pf-m-overflow-scroll y .pf-m-shadow-bottom. Aclara si las sombras dinámicas deben aplicarse de forma general o solo a las secciones de página, incluidas las expectativas de rendimiento y los estados de desplazamiento deseados. Se considera completado cuando el alcance y el comportamiento se hayan acordado antes de comenzar la implementación.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- css, react, typescript
- Área
- design, frontend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Tranquilo
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 30/100