patternfly / patternfly/patternfly-react
Bug - Notification Drawer should allow focus trap
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the problem
A clear and concise description of the problem. Which pages are affected?
When using a keyboard to navigate the page in https://www.patternfly.org/components/notification-drawer/react-demos/basic/, keyboard focus is given to the first button or link in the drawer, which is correct.
However, when a user goes and closes the notification drawer, keyboard focus does not return to the notification button, and seems to return to the browser chrome, which is disorienting.
Moreover, after tabbing to the last item in the notification drawer, the next tab press should loop back to the first item in the notification drawer; however, this is not done.
Expected behavior
A clear and concise description of the expected behavior.
In the demo, keyboard focus should be returned to the notification badge after the notification drawer is closed, and the keyboard focus should be trapped entirely within the notification drawer when it is open.
Screenshots
If applicable, add screenshots to help explain the issue.
Any other information?
See this blog post:
https://codepen.io/unleashalicia/pen/YzXrJBN
https://knowbility.org/blog/2020/accessible-slide-menus
Jira Issue: PF-1354
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从所链接的 PatternFly 页面上的 React notification-drawer 基础演示开始,并查看所链接的 focus-management 示例。验证 drawer 当前的键盘行为,然后确保关闭时 focus 返回 notification badge,并在打开的 drawer 内循环;在演示中验证这两种行为。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- accessibility, frontend
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100