patternfly / patternfly/patternfly-react

Bug - Password Generator - Inconsistent Demo Layout in Docs (HTML vs TSX Demos)

未关闭
#11,633 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Stale
主要语言
TypeScript
星标
862
派生
392
平均合并
4 天 8 小时
30 天内合并 PR
9

描述

Describe the problem

In the docs for Password Generator, there is an issue with the layout of the demo.

The HTML demo uses a FormGroup component, which renders the demo at the correct width (with a max-width of 825px set in the docs framework).

The TSX demo uses the InputGroup component, which seems to be the new recommended React component for this functionality. However the InputGroup demo is rendered at a very small width, making the code editor and the demo code difficult to read:

Image Image

How do you reproduce the problem?

  1. Go to the React docs for Password Generator
  2. See the TSX demo using InputGroup, which is collapsed and has a narrow width.
  3. Compare to the HTML demo using FormGroup which has the proper layout.

Expected behavior

TSX demo for the Password Generator should be displayed with the same layout and width as the HTML demo.

Screenshots

See above

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Chrome

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 React Password Generator 文档页面开始,将 TSX InputGroup 演示与 HTML FormGroup 演示进行比较。检查 packages/documentation-framework/templates/mdx.js 中链接的文档框架模板,然后确认 TSX 演示具有与 HTML 演示相同的可读宽度和布局。

由索引模型根据 Issue 内容生成。

评估

技术栈
react, typescript
领域
documentation, frontend
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。