patternfly / patternfly/patternfly-react
MenuToggle - add aria-controls prop to relate toggle and content it controls
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the problem
With PF6, the dropdown menu popover is by default parented to the root. When the menu is open, there is no attribute which relates the popover menu back to the toggle button which opened it.
react-table ActionColumn is an example where PF owns both components but there's still no relation. It would be possible to override the MenuToggle by supplying a custom actionsToggle function.
In writing this issue, I realize it may not be possible without "hacks" for PF to relate the two when the application controls the rendering of both the toggle and menu separately.
Having a relationship between the two at the dom level would help with test automation such as cypress.
How do you reproduce the problem?
Go to https://www.patternfly.org/components/menus/dropdown
Open a dropdown menu
Using web inspector, inspect the dropdown toggle and popover menu parented to the root. Observe there is no attribute relating the two.
Expected behavior
Expected some attribute present, wether arbitrary or a11y requirement, to relate the two dom nodes.
Is this issue blocking you?
It is possible to supply an ID which then gets applied to the popover menu.
What is your product and what release date are you targeting?
RHOAI
Jira Issue: PF-998
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 PatternFly dropdown 文档示例和 issue 中描述的 MenuToggle API 开始。跟踪 toggle 和以 root 为父元素的 popover 是如何渲染的,然后定义 props 的行为,使这两个 DOM 节点建立关系;在 dropdown 示例及其可用的无障碍性或交互测试中验证结果。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- accessibility, frontend
- Issue 类型
- 功能
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 58/100