patternfly / patternfly/patternfly-react

Table sorting needs clarification/revisement

未关闭
#11,006 10 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

PF Team Stale
主要语言
TypeScript
星标
862
派生
392
平均合并
4 天 8 小时
30 天内合并 PR
9

描述

Describe the enhancement or change
From the 9/16/2024 design share session, sorting was a topic mentioned, including how "favorites" sorting should work (since typically there's no text to sort by, only an icon).

I gave my initial thoughts on this in the design share, mentioning that if you view it in a sort of alphabetical order, "Favorited" comes before "Unfavorited"/"Not favorited", so following that logic an ascending sort order (with the arrow UP icon) should sort rows so that favorited rows are first (right now our favoritable example does the opposite). Of course this logic kind of breaks depending on the verbiage you're using: "Starred" comes alphabetically after "Not starred". Perhaps if we view it more as an 'active" and "inactive" state universally that logic would fit in all situations, though.

What we should do:

  • Investigate how "favorited" rows should be sorted based on the sort type and what icon should be used; we should see if there's a common pattern for this elsewhere, then from there we may need to update logic in our code.

  • Depending on the outcome of the above, we should make sure we make applicable updates in the core repo as well as update any design guidelines

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?


Jira Issue: PF-16

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 PatternFly 表格的 favoritable 示例开始,检查 issue 中描述的排序行为。研究对收藏行或活动/非活动行进行排序时的常见约定,然后确定 core repository 和设计指南中所需的更新。当行为和排序图标达成一致,并且适用的文档和实现变更已定义时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
react, typescript
领域
design, frontend
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
冷清
描述清晰度
基本清楚
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。