patternfly / patternfly/patternfly-react
Bug - [Popover] - [accessibility issues with footer, header, and heading]
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the problem
Accessibility issues for Popover element:
- with
footerContentprop - with
headerContentprop - with default value
h6ofheaderComponentprop
Heading levels should only increase by one
https://dequeuniversity.com/rules/axe/4.9/heading-order
<h6 class="pf-v5-c-popover__title-text"><div>Popover header</div></h6>
Document should not have more than one banner landmark
https://dequeuniversity.com/rules/axe/4.9/landmark-no-duplicate-banner
<header class="pf-v5-c-masthead pf-m-display-inline ws-masthead">
Related node:
<header class="pf-v5-c-popover__header"><div class="pf-v5-c-popover__title" id="popover-pf-17234753664484trsgdfq2md-header"><h6 class="pf-v5-c-popover__title-text"><div>Popover header</div></h6></div></header>
Document should not have more than one contentinfo landmark
https://dequeuniversity.com/rules/axe/4.9/landmark-no-duplicate-contentinfo
<footer class="pf-v5-c-page__main-section ws-org-pfsite-l-footer">
Related node:
<footer class="pf-v5-c-popover__footer" id="popover-pf-17234753664484trsgdfq2md-footer">Popover footer</footer>
Ensures landmarks are unique
https://dequeuniversity.com/rules/axe/4.9/landmark-unique
<header class="pf-v5-c-masthead pf-m-display-inline ws-masthead">
Related node:
<header class="pf-v5-c-popover__header"><div class="pf-v5-c-popover__title" id="popover-pf-17234753664484trsgdfq2md-header"><h6 class="pf-v5-c-popover__title-text"><div>Popover header</div></h6></div></header>
<footer class="pf-v5-c-page__main-section ws-org-pfsite-l-footer">
Related node:
<footer class="pf-v5-c-popover__footer" id="popover-pf-17234753664484trsgdfq2md-footer">Popover footer</footer>
How do you reproduce the problem?
- Visit https://www.patternfly.org/components/popover/#basic
- Click Toggle popover button.
- Scan page with axe DevTools and ignore the last issue as irrelevant.
Expected behavior
Render markup that passes axe DevTools rules.
Is this issue blocking you?
No, we will fix 10 occurrences as follows:
- Move occurrences of
footerContent, orheaderContent, or both, to props of a pure presentation component that composes them withbodyContentand returns markup forbodyContentprop ofPopoverelement. That is, replacefooterandheaderelements withdivelements that have PatternFly classes for same visual appearance. - Render (instead of heading element)
pelement that has PatternFly class for same visual appearance, but takes out of heading hierarchy of page. Similar solution as our workaroundcomponent="p"prop forAlertelements that do not seem to fit heading hierarchy of page.
Screenshots
What is your environment?
- OS: macOS 14.6.1
- Browser: Chrome 127
- PatternFly: react-core 5.2.2
What is your product and what release date are you targeting?
Red Hat Advanced Cluster Security
Any other information?
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Popover 组件和 patternfly.org/components/popover/#basic 上的基本 Popover 示例开始,然后使用 axe DevTools 重现报告的违规问题。更新这十处,使 footer 和 header 内容使用非 landmark 的 presentation 标记,并使默认 header 不再添加不恰当的标题级别;当报告的 axe 规则通过时即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- accessibility, frontend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100