paritytech / paritytech/try-runtime-cli

Should be able to pass all `live` state arguments to the `execute_block` command

Open
#94 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
25
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Problem

I've noticed that the pallet, hashed_prefixes & child_tree arguments are not passed to the execute_block command when testing storage invariants with try-state. Here is my command:

try-runtime \                        
--runtime ./target/release/wbuild/astar-runtime/astar_runtime.wasm \
execute-block \
--try-state DappStaking \
live --uri wss://rpc.astar.network:443 --pallet DappStaking

This log is always printed:

[2024-08-20T08:39:00Z INFO  remote-ext] since no prefix is filtered, the data for all pallets will be downloaded
Solution

I suggest adjusting the following section by removing the default method:

https://github.com/paritytech/try-runtime-cli/blob/60cfc452c4c1f5de0bcfa85e1e8dbba8ae8d3ebc/core/src/commands/execute_block.rs#L114C17-L120C18

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading core/src/commands/execute_block.rs around lines 114-120 and compare the execute-block live arguments with the example command in the issue. Run the shown try-runtime command against the Astar runtime and verify that pallet, hashed_prefixes, and child_tree reach the live storage setup instead of downloading all pallets.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.