Affinity/anti-affinity: error message on member add request can be more user-friendly
@smklein is already working on this.
Since Mar 13, 2025.
Assessment
This issue has not been assessed yet.
Description
The current error message mentions "reservation" but it's not something user necessarily understands:
$ oxide api /v1/anti-affinity-groups/mongodb-cluster/members/instance/mongodb-xfs-bs4096-primary?project=try -X POST
error; status code: 400 Bad Request
{
"error_code": "InvalidRequest",
"message": "Instance cannot be added to anti-affinity group with reservation",
"request_id": "1406575f-936d-458e-87a1-ec3cd18306be"
}
error
The vmm reservation check is internal to the control plane. For API users, we probably want to frame the error in terms of instance state or the action to take, e.g., "Instance must be stopped to be added to an anti-affinity group".
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oxidecomputer/omicron
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
oxidecomputer/omicron#11269 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
oxidecomputer/omicron#11266 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
oxidecomputer/omicron#11260 · 1 comment ·
-
wicket's errors should be better when trying to read sensitive data from ssh without a pseudo-tty Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
oxidecomputer/omicron#11148 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
oxidecomputer/omicron#10907 ·
All issues in oxidecomputer/omicron
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100