wicketd requests to MGS fail with HTTP 400 and a 0-length response body

Open
#3,103 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
networking

Research direction

Reproduce the next simultaneous dogfood-rack mupdate while capturing localhost traffic with snoop -o mgs-traffic.snoop -x0 -d lo0 port 12225. Compare the capture with the HTTP 400 failures and the absence of MGS log entries, then determine whether affected wicketd requests need retries. No source files or tests are named in the issue.

Written by the indexing model from the issue text.

Description

Today when trying to update 6 gimlets in the dogfood rack simultaneously, three of the updates failed partway through because wicketd got an HTTP 400 with no body response from MGS. There was no corresponding entry in the MGS logs, which makes it very likely hyper itself was sending the 400, which it does if it receives a non-HTTP request. https://github.com/hyperium/hyper/issues/3225 is a request for better after-the-fact debugging support from hyper, but in the meantime, the next time we try to mupdate the dogfood rack we should snoop the localhost traffic between wicketd and MGS in hopes of catching details on what's causing these 400s:

snoop -o mgs-traffic.snoop -x0 -d lo0 port 12225

We should (probably?) also add some kind of retries around at least some of the requests wicketd makes of MGS.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/omicron

All issues in oxidecomputer/omicron

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.