optimizely / optimizely/java-sdk

Pick Serializer using properties

Abierto
#492 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Java
Estrellas
44
Forks
32
Merge medio
8 h 39 min
PR fusionados (30 d)
1

Descripción

Hello Optimizely team:

We have encountered issues while working with Optimizely. The SDK allows to use two different serialisers in an uncontrolled way, by letting you pick one using optimizely.properties (in out experience, it is used while retrieving your organisation experiments file, I don't know for what else it is used):
DefaultConfigParser

But in this one where the events are raised, since it is an if/else structure, you have no control over it, and in our case it does not work because we use a Jackson version previous to 2.7, throwing an exception while trying to create it with the SNAKE_CASE property (one exception that we will avoid if GSON could be chosen):
DefaultJsonSerializer

I feel like this is an inconsistency and since it is already implemented for one scenario, it should be paired for the event ones.
We also know that this is our fault for not using that Jackson version, but it is done in a service where that specific library is almost impossible to update... We have discarded the idea of integrating Optimizely in that specific service, but we thought that it was important to let you know this weird behaviour where you can have GSON (or any other one) + Jackson (or any other one) working simultaneously.

Thanks for reading, let us know if you change anything about this!

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza comparando core-api/src/main/java/com/optimizely/ab/config/parser/DefaultConfigParser.java con core-api/src/main/java/com/optimizely/ab/event/internal/serializer/DefaultJsonSerializer.java, centrándote en cómo optimizely.properties selecciona un serializer. Confirma que la serialización de eventos puede respetar la misma selección y verifica que las configuraciones de GSON y Jackson funcionen de forma coherente.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java
Área
api
Tipo de issue
Nueva funcionalidad
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.