openpharma / openpharma/graphicalMCP
Check power for edge cases marginal power 0 or 1
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 21
- Forks
- 1
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 11
Description
Results are currently different for calculate_power(g, marginal_power = c(0, 0, 0), sim_seed = 51123, force_closure = TRUE) and calculate_power(g, marginal_power = c(0, 0, 0), sim_seed = 51123).
Should validation exclude 0/1 for marginal power?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the calculate_power function and trace validation and the force_closure path for marginal_power values of 0 and 1. Compare both calls in the issue using the supplied sim_seed, then determine and document the expected consistent behavior for these boundary values. Done means the edge case is handled consistently and covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100