openfrontio / openfrontio/OpenFrontIO
Encirclement does not work on map edges
- Lenguaje dominante
- TypeScript
- Estrellas
- 2.7k
- Forks
- 1.4k
- Merge medio
- 16 h 29 min
- PR fusionados (30 d)
- 327
Descripción
**Describe the bug**
So far I am aware of this strategy/feature "encirclement": if player A's land fully surrounds player B's land (NPC or not), then player B instantly loses and the land becomes owned by player A.
However, this does not work on map edges.
**To Reproduce**
Steps to reproduce the behavior:
1. Start near map edge (Player A)
2. Find a player that is at the map edge (Player B)
3. Surround Player B
4. No encirclement is triggered
**Expected behavior**
Encirclement should occur and Player B loses.
**Screenshots**
(Not screenshot, but an illustration of the situation.)
Consider this hypothetical scenario, where the colors are:
- White: unowned/neutral
- Red: Player A
- Blue: Player B
- Black: out-of-bounds area / map edge
Then, Player A should have encircled Player B, and Player B should lose.
**Desktop (please complete the following information):**
- OS: Windows
- Browser: Firefox
- Version 152
**Additional context**
It may be a good idea to also check lake-side / ocean-side encirclement, to ensure encirclement still works as expected.
**Assignment**
- [ ] I'd like to be assigned to this issue and work on it myself
Guía de contribución
Línea de trabajo
Comienza reproduciendo el escenario del borde del mapa descrito en el issue y, después, compáralo con un cerco junto a un lago o al océano. Sigue la comprobación del cerco desde el punto de entrada del gameplay; se considerará terminado cuando un jugador completamente rodeado en el borde del mapa pierda y cambie la propiedad, mientras el comportamiento existente fuera del borde siga siendo correcto.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- game-dev
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 62/100