openapi-generators / openapi-generators/openapi-python-client
Attempted to generate duplicate models with name "TypenameFieldnameItem"
Personne n'a encore pris cette issue.
- Langage dominant
- Python
- Étoiles
- 2k
- Forks
- 293
- Merge moyen
- 34 min
- PR mergées (30 j)
- 1
Description
Describe the bug
I stumbled on a weirdly specific bug that causes the generator to attempt to generate duplicate models.
Apparently we need:
- a OneOf type (A), which references an Object type (B)
- An object type (B) with an array-of-object field
- An Object type (C) for the array-of-object field
- array-of-C and C must be declared inline inside B
OpenAPI Spec File
This works
openapi: 3.0.3
info:
title: Minimal example for error "Attempted to generate duplicate models"
version: 1.0.0
components:
schemas:
Result:
oneOf:
- $ref: "#/components/schemas/ResultA"
discriminator:
propertyName: type
mapping:
"A": "#/components/schemas/ResultA"
ResultA:
type: object
properties:
things:
type: array
items:
$ref: "#/components/schemas/ResultAThingsItem"
ResultAThingsItem:
type: object
properties:
name:
type: string
paths:
/something:
get:
summary: Returns a list of users.
responses:
'200':
description: A successful response returning the list of users.
content:
application/json:
schema:
$ref: '#/components/schemas/Result'
This should be the same, but doesn't work:
openapi: 3.0.3
info:
title: Minimal example for error "Attempted to generate duplicate models"
version: 1.0.0
components:
schemas:
Result:
oneOf:
- $ref: "#/components/schemas/ResultA"
discriminator:
propertyName: type
mapping:
"A": "#/components/schemas/ResultA"
ResultA:
type: object
properties:
things:
type: array
items:
type: object
properties:
name:
type: string
paths:
/something:
get:
summary: Returns a list of users.
responses:
'200':
description: A successful response returning the list of users.
content:
application/json:
schema:
$ref: '#/components/schemas/Result'
Output:
$ pipx run openapi-python-client generate --path=example.yaml --overwrite
Generating <...>/minimal-example-for-error-attempted-to-generate-duplicate-models-client
Warning(s) encountered while generating. Client was generated, but some pieces may be missing
WARNING parsing GET /something within default.
Cannot parse response for status code 200 (Could not find reference in parsed models or enums), response will be omitted from generated client
Reference(ref='#/components/schemas/Result')
Unable to process schema /components/schemas/Result:
Attempted to generate duplicate models with name "ResultAThingsItem"
Failure to process schema has resulted in the removal of:
/components/schemas/ResultA
/components/schemas/Result
Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, const=None, type=<DataType.OBJECT: 'object'>, allOf=[], oneOf=[], anyOf=[], schema_not=None, items=None, prefixItems=[], properties={'name': Schema(title=None, multipleOf=None, maximum=None, exclusiveMaximum=None, minimum=None, exclusiveMinimum=None, maxLength=None, minLength=None, pattern=None, maxItems=None, minItems=None, uniqueItems=None, maxProperties=None, minProperties=None, required=None, enum=None, const=None, type=<DataType.STRING: 'string'>, allOf=[], oneOf=[], anyOf=[], schema_not=None, items=None, prefixItems=[], properties=None, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None)}, additionalProperties=None, description=None, schema_format=None, default=None, nullable=False, discriminator=None, readOnly=None, writeOnly=None, xml=None, externalDocs=None, example=None, deprecated=None)
If you believe this was a mistake or this tool is missing a feature you need, please open an issue at https://github.com/openapi-generators/openapi-python-client/issues/new/choose
**Desktop (please complete the following information):**
- OS: Ubuntu 25.04
- Python Version: 3.12.3
- openapi-python-client version: 0.28.0
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par exécuter openapi-python-client generate --path=example.yaml --overwrite avec les deux schémas de l’issue, puis suivez le point d’entrée de la génération des modèles qui prend en charge l’élément de tableau inline et le modèle référencé. Le travail est terminé lorsque la forme inline ne signale plus de modèle ResultAThingsItem en double et que la réponse GET est conservée dans le client généré.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- openapi, python
- Domaine
- api, tooling
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 55/100