open-rmf / open-rmf/rmf_simulation
[Feature request]: Remove rmf_robot_sim_common package
Open
@xiyuoh is already working on this.
Since Dec 13, 2024.
enhancement
- Dominant language
- C++
- Stars
- 21
- Forks
- 30
- PR merge metrics
- No merged PRs in 30d
Description
Before proceeding, is there an existing issue or discussion for this?
- I have done a search for similar issues and discussions.
Description
The rmf_robot_sim_common package is no longer necessary since we don't need to support gazebo classic anymore, on the contrary it makes the code for plugins unnecessarily complicated (i.e. having a callback based system for ingestors / dispensers).
We should get rid of it, which will remove one package from this repo and make the code quite a lot easier to maintain.
Implementation Considerations
No response
Alternatives
No response
Additional information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.