Add check to prevent the same buffer appearing more than once in a single join
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 72
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Right now it is technically possible for a user to specify the same buffer multiple times within one join operation, but this would result in a Broken error while the workflow is running.
We should instead check whether the same buffer has been put multiple times into the join while building the join instead of risking a runtime problem. We can introduce a new safe_join method that returns a Result, and the existing join method just unwraps safe_join.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing join method and reading how it builds and reports Broken errors. Trace the join construction path and verify that duplicate buffers return an error through safe_join while join preserves its existing unwrapping behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100