More comprehensive tests for trimming
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 72
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Before proceeding, is there an existing issue or discussion for this?
- I have done a search for similar issues and discussions.
Description
We support an operation for "trimming" a workflow, meaning cancelling any activity going on within a specified span of the workflow. We have a rudimentary test for this operation, but it would be good to have more comprehensive tests, especially tests that ensure the span calculation is working correctly.
Tests to validate the span calculations could be done with unit tests inside of operate_trim.rs that manually build pseudo-workflow topologies by spawning entities with the right components, rather than spawning an entire proper workflow.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in operate_trim.rs and inspect the existing rudimentary trimming test and span-calculation logic. Build pseudo-workflow topologies by spawning entities with the required components, then add unit tests covering span calculations and verify the trimming behavior against those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100