Prevent async channels from sending streams after the service finishes
Open
@mxgrey is already working on this.
Since Oct 26, 2024.
- Dominant language
- Rust
- Stars
- 72
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Currently it is possible for a user to implement an async service that sends its async channel outside of the function scope so that the channel can outlive the function scope. Then the channel could continue to be used to transmit new stream signals after the service has terminated.
This violates bevy_impulse's contract that services cannot produce stream data after their final output has been delivered.
We should put a mechanism into the async channel that allows us to close it once we have received the final output for the service call that the channel was created for.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.