open-rmf / open-rmf/crossflow

[Diagram Editor] Bug in type inference for unzip

Open
#223 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
72
Forks
16
PR merge metrics
No merged PRs in 30d

Description

I've noticed inconsistencies when creating Unzip operations.

  • Sometimes the Unzip operation shows up in the Compatible next operations when it shouldn't.
  • Sometimes you're allowed to connect to unzip when you shouldn't
  • Sometimes the connection helper shows green for unzip, despite having an incompatibility
  • Sometimes the connection helper shows red for unzip but still allows the connection be created

I'm not sure if these things happen for any other operation, I've only tested this out with Unzip after noticing an error occur.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Unzip cases in the diagram editor: compatible next operations, connection creation, and the connection helper's green or red state. Trace the type-inference and compatibility checks used by these entry points, comparing their results for Unzip. Done means all three surfaces consistently reject incompatible connections and allow compatible ones.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.