open-AIMS / open-AIMS/ReefMonitoring-DataClient

Hoist hardcoded temporal range (1992:2025) into a shared const

Open Beginner friendly
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
1
Forks
0
Avg merge
1m
Merged PRs (30d)
2

Description

temporal_range = 1992:2025 is duplicated in three places in src/processing.jl:

  • _add_taxa_cover! (line 76)
  • depth_composition (line 105)
  • multiple_location_stat (timesteps = 1992:2025, line 223)

These must stay in sync for the composition matrices to line up. Replace with a single module-level const (e.g. const TEMPORAL_RANGE = 1992:2025) and reference it everywhere.

Maintainability / reproducibility improvement, not a bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/processing.jl and inspect _add_taxa_cover!, depth_composition, and multiple_location_stat where the temporal range is currently defined. Introduce the shared module-level constant and verify that all three entry points reference it, with no duplicated temporal-range literal remaining.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
90/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.