onepub-dev / onepub-dev/dcli_scripts
Update bin/dwhich.dart?
Nobody has claimed this yet.
- Dominant language
- Dart
- Stars
- 16
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Hey there @bsutton -- getting into all of this.
Could you confirm that dwhich.dart needs to be updated?
It seems to be still using an old Args class from an earlier version of DCLI (3.x.x?)
It also seems that the new ExitException in DCLI 4.x found here:
https://github.com/onepub-dev/dcli/blob/master/dcli_sdk/lib/src/util/exit.dart
or here:
https://github.com/onepub-dev/dcli/blob/master/dcli_sdk/lib/src/util/exceptions.dart
And perhaps a related class here:
https://github.com/onepub-dev/dcli/blob/master/dcli_core/lib/src/util/dcli_exception.dart
and here:
https://github.com/onepub-dev/dcli/blob/master/dcli_core/lib/src/util/run_exception.dart
Let me know if this is relevant/related, happy to get this updated with a bit of direction!
Cheers,
-Tsavo
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with bin/dwhich.dart and compare its Args and exception usage with the DCLI 4.x files linked in the issue: dcli_sdk/lib/src/util/exit.dart, dcli_sdk/lib/src/util/exceptions.dart, dcli_core/lib/src/util/dcli_exception.dart, and dcli_core/lib/src/util/run_exception.dart. Confirm which APIs are outdated and define completion as dwhich.dart being updated for the relevant DCLI 4.x interfaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- dart
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100