nodejs / nodejs/node

deps: backport V8 LLE alias fix to 26.x and 24.x

Aperta
#66,112 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
JavaScript
Stelle
122k
Fork
37.3k
Merge medio
4g 2h
PR unite (30g)
283

Descrizione

Summary

Please backport V8 commit b44239fe / V8 bug 554421904, "Turboshaft LLE: non-writing calls can create aliases", to the active Node.js 26.x and 24.x release lines.

This is the same upstream V8 miscompilation tracked in #66083 for 26.x, but 24.x is also affected by default: Node 24 ships V8 13.6 with Turboshaft load elimination enabled by default, and the minimized reproducer returns the wrong value there too.

Version

Reproduced locally with:

  • v26.9.0 / V8 14.6.202.34-node.32
  • v24.18.0 / V8 13.6.233.17-node.50

Source check after fetching current tags/branches:

  • upstream/v26.x and upstream/v26.x-staging: V8 14.6.202.34, no regress-554421904 test
  • upstream/v24.x and upstream/v24.x-staging: V8 13.6.233.17, no regress-554421904 test

Platform

macOS arm64

This appears to be a compiler optimization bug rather than platform-specific behavior.

Subsystem

V8 / deps

What steps will reproduce the bug?

Run the minimized reproducer from #66083 with native syntax enabled:

node --allow-natives-syntax v8-lle-poc.js

I also checked the relevant runtime flag defaults:

  • 26.x: --turboshaft-load-elimination is enabled by default
  • 24.x: --turboshaft-load-elimination is enabled by default
  • 22.x: --turboshaft-load-elimination is disabled by default, so this request is intentionally limited to 26.x and 24.x

How often does it reproduce? Is there a required condition?

It reproduced consistently for me on both default-affected lines listed above.

The reproducer requires optimized code and the Turboshaft load-elimination pass. That pass is enabled by default on the Node 26 and Node 24 builds tested.

What is the expected behavior? Why is that the expected behavior?

The store to staleArray[7] should be preserved, so the returned array slot should contain 1.1:

staleArray[7]: 1.1 | expected: 1.1 | OK
RESULT: NOT TRIGGERED on this build

What do you see instead?

Node 26:

v26.9.0 V8 14.6.202.34-node.32
staleArray[7]: undefined | expected: 1.1 | WRONG!
RESULT: BUG TRIGGERED — Turboshaft LLE eliminated a valid store

Node 24:

v24.18.0 V8 13.6.233.17-node.50
staleArray[7]: undefined | expected: 1.1 | WRONG!
RESULT: BUG TRIGGERED — Turboshaft LLE eliminated a valid store

Additional information

The upstream fix is small and directly addresses the alias invalidation ordering in Turboshaft late load elimination:

The current 26.x and 24.x V8 snapshots still have the vulnerable early !op.Effects().can_write() bailout before invalidating non-aliasing inputs in deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.cc.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.cc e confronta gli snapshot V8 attivi 26.x e 24.x con il commit upstream b44239fe. Esegui v8-lle-poc.js usando node --allow-natives-syntax su entrambe le linee di release, quindi verifica che il fix upstream e la coverage di regress-554421904 siano presenti e che il reproducer restituisca 1.1.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript
Ambito
compilers, release
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Specificata chiaramente
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.