test_runner: allow adapters to handle individual unhandled promise rejections
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.3k
- 平均合并
- 4 天 2 小时
- 30 天内合并 PR
- 283
描述
What is the problem this feature will solve?
(AI disclosure: text written by GPT-6 Astra Extra High, then read, tweaked, and signed-off on by @domenic.)
We are migrating jsdom's tests to node:test. Our Web Platform Tests adapter runs each WPT file inside a jsdom instance, waits for the embedded testharness.js harness to finish, and checks its results against our expectations.
Some WPTs deliberately produce unhandled rejections in iframe windows. These do not necessarily constitute failures of the parent window's test harness. Other rejections should become harness failures, which the adapter needs to evaluate against expected failures for unimplemented functionality.
Currently, node:test fails and aborts the enclosing test when it observes an unhandled rejection, before our adapter can finish evaluating the WPT. Adding our own process.on("unhandledRejection") listener does not prevent the test runner from independently failing the test.
We need a supported way for an embedded test harness to take responsibility for selected rejections, while preserving normal test-runner failure handling for unrelated rejections.
What is the feature you are proposing to solve the problem?
A per-test hook that can handle individual unhandled rejections before the test runner automatically fails or aborts the test.
For example, the API could look like this:
test("embedded harness", {
onUnhandledRejection(reason, promise) {
if (!adapter.ownsPromise(promise)) {
return false;
}
adapter.recordUnhandledRejection(reason, promise);
return true;
}
}, async () => {
await adapter.run();
adapter.assertExpectedResults();
});
The important capabilities would be:
- The hook receives both the rejection reason and the actual promise, allowing the adapter to identify ownership.
- Returning
trueindicates that the adapter accepts responsibility for the rejection. The test runner does not automatically fail or abort the test for that rejection. - Returning
falseorundefinedpreserves current behavior. Throwing from the hook fails the test.
A couple more points GPT-6 Astra Extra High thought were important to include, but seem obvious to @domenic
- Rejections are attributed to the originating test's asynchronous context, including rejections reported after that test finishes. A claimed late rejection should not independently cause the test file to fail; unclaimed late rejections should retain current behavior.
- The hook controls only the test runner's response. It does not suppress other process listeners or change the process's configured unhandled-rejection policy.
This would let adapters classify rejections and finish checking their results without requiring Node to understand the embedded harness's semantics. The adapter would remain responsible for waiting for relevant rejection notifications before completing its test.
What alternatives have you considered?
Stuff that doesn't work that we tried
- Adding a process-level
unhandledRejectionlistener, including a prepended listener. The test runner still receives the event and fails the test. - Using
--unhandled-rejections=none. This suppresses warnings, but does not prevent the test runner from failing the test. - Using
expectFailure. This still lets the runner fail and abort the test instead of letting the embedded harness finish evaluating its results.
Stuff that works but is icky
- Wrapping
process.emitto intercept selected rejection events. Small probes work on Node 22, 24, and 26 while preserving failure handling for unrelated rejections, but this requires monkeypatching and depends on the runner's reporting mechanism. - Using
node:domain. This can redirect rejections, but the API is deprecated and affects more than rejection reporting. - Running the embedded harness in a separate process. This provides control over rejection handling, but adds process management and communication infrastructure.
- Skipping the affected tests. This avoids the immediate failures but loses regression coverage compared to mocha.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 node:test runner 当前对未处理 rejection 的处理开始,以 jsdom WPT adapter 场景和列出的进程级替代方案作为复现上下文。定义对已认领、未认领、抛出错误和延迟 rejection 的覆盖范围;完成的标准是,针对性测试确认已认领的 rejection 不会中止外层 test,而不相关的 rejection 保持当前行为。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, node.js
- 领域
- testing-qa
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100