nodejs / nodejs/node

TLS memory overflow - V8 garbage collection

Aperta
#65,263 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

tls
Lingua principale
JavaScript
Stelle
122k
Fork
37.3k
Merge medio
4g 2h
PR unite (30g)
283

Descrizione

Version

26.7.0

Platform
Microsoft Windows NT 10.0.26200.0 x64
Subsystem

No response

What steps will reproduce the bug?
  1. git clone https://github.com/prettydiff/aphorio
  2. npm run server
  3. Open a web browser to localhost and the specified port number
  4. In the browser use the left side navigation and choose Performance Test
  5. Choose these experiment settings:
    • WebSocket
    • Encrypted
    • Send Only
    • Force GC Between Tests
    • Location - 127.0.0.1
    • Port - specified secure port
    • Test Quantity - 5000000
    • Number of tests - 10
    • Message Body - "test"
How often does it reproduce? Is there a required condition?

50%, no required condition

What is the expected behavior? Why is that the expected behavior?

The expected behavior is the application remains executing and returns test results.

What do you see instead?
<--- Last few GCs --->

[16960:00000220C3725000]   178739 ms: Scavenge (during sweeping) 7914.8 (7952.1) -> 7887.9 (7954.4) MB, pooled: 0.0 MB, 3.29 / 0.00 ms (average mu = 0.348, current mu = 0.370) allocation failure;
[16960:00000220C3725000]   179468 ms: Incremental Mark-Compact (reduce) 7919.9 (7957.1) -> 7890.5 (7896.4) MB, pooled: 0.0 MB, 33.63 / 0.00 ms (+ 668.4 ms in 133 steps since start of marking, biggest step 5.2 ms, walltime since start of marking 720 ms) (a
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 00007FF748A7641D node::OnFatalError+1325
 2: 00007FF749840FB1 v8::Function::NewInstance+577
 3: 00007FF749625287 SSL_CTX_set_stateless_cookie_verify_cb+504087
 4: 00007FF749622E4D SSL_CTX_set_stateless_cookie_verify_cb+494813
 5: 00007FF74961D511 SSL_CTX_set_stateless_cookie_verify_cb+471969
 6: 00007FF749624DEA SSL_CTX_set_stateless_cookie_verify_cb+502906
 7: 00007FF7493C8C8F v8::MemorySpan<v8::internal::DirectHandle<v8::internal::Map> >::operator[]+890943
 8: 00007FF749665ADE v8::internal::StrongRootAllocatorBase::deallocate_impl+201886
 9: 00007FF74986B73C v8::ArrayBuffer::New+172
10: 00007FF748AD2A7F node::Buffer::New+43359
11: 00000220EBD501DA
Additional information

Unencrypted tests never fail in this manner as they will run to completion as long as it takes. This problem is specific to TLS. I have been able to run experiments comprising greater than 50,000,000 WebSocket messages repeatedly without any failures.

The error messaging indicates garbage collection in V8 is the culprit, but I suspect the problem could be OpenSSL causing V8 to hang unexpectedly until all memory is consumed.

This is an aside, but it seems at maximum efficiency I can send 3,250,000 messages in 0.002 seconds but the next 0.998 seconds is spent on garbage collection. I don't know if this is a potentially untapped optimization target. Aside from the garbage collection time it seems executing WebSockets like this application does is about 2300x faster than Bun.
I had a defect in my profiler.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Riprodurre con il repository aphorio usando npm run server e le impostazioni del WebSocket Performance Test crittografato descritte nell’issue. Confrontare l’esecuzione TLS con quella non crittografata osservando l’output del garbage collection di V8 e dell’errore dell’heap. Il lavoro è completato quando il test crittografato termina e restituisce i risultati senza esaurire la memoria.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript, nodejs
Ambito
backend, networking, security
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.