watch mode triggers unsolicided messages to Workers
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.4k
- 平均合并
- 4 天 3 小时
- 30 天内合并 PR
- 272
描述
Version
24.19.0, 26.6.0
Platform
Linux 05338a186e89 6.18.33.1-microsoft-standard-WSL2 #1 SMP PREEMPT_DYNAMIC Fri Jun 5 01:12:21 UTC 2026 x86_64 Linux
Subsystem
worker
What steps will reproduce the bug?
given the following two files:
// main.mjs
import { Worker } from 'worker_threads'
const worker = new Worker('./worker.js')
worker.on('message', console.log)
// worker.js (can be empty)
it can be reproduced using node --watch main.mjs.
The behavior is identical when using an equivalent main.cjs instead.
How often does it reproduce? Is there a required condition?
reproduces consistently
What is the expected behavior? Why is that the expected behavior?
applications should not receive unexpected (and undocumented) messages by the engine.
What do you see instead?
Unsolicided "watch:require" messages are sent.
Additional information
This issue effects v24 and v26, as can be seen in the following log (tested with node.js v22.23.1, v23.11.1, v24.19.0, v25.9.0, v26.6.0; note that I aborted each run with ctrl+c)
$ docker run --rm -v .:/app -w /app node:22-alpine node --watch main.mjs
Completed running 'main.mjs'. Waiting for file changes before restarting...
$ docker run --rm -v .:/app -w /app node:23-alpine node --watch main.mjs
Completed running 'main.mjs'
$ docker run --rm -v .:/app -w /app node:24-alpine node --watch main.mjs
{ 'watch:require': [ '/app/worker.js' ] }
Completed running 'main.mjs'. Waiting for file changes before restarting...
$ docker run --rm -v .:/app -w /app node:25-alpine node --watch main.mjs
Completed running 'main.mjs'. Waiting for file changes before restarting...
$ docker run --rm -v .:/app -w /app node:26-alpine node --watch main.mjs
{ 'watch:require': [ '/app/worker.js' ] }
Completed running 'main.mjs'. Waiting for file changes before restarting...
Though robust message handling code should always validate and check received messages, such unexpected messages can lead to unexpected behavior, e.g. crashes. This unexpected node.js behavior leads to the following issue downstream with an XML schema validating library: https://github.com/noppa/xmllint-wasm/issues/37
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先使用 main.mjs、worker.js 和 node --watch 运行已报告的复现步骤,然后跟踪发出 "watch:require" 消息的 worker 和 watch 模式处理逻辑。完成的标准是:在此情况下 worker 不会收到任何非请求消息,并且针对这一始终可复现的行为具备回归覆盖。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, node.js
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 55/100