nodejs / nodejs/node

`test-code-cache` fails on a Linux/riscv64 build with FFI enabled.

未关闭
#64,717 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

ffi riscv64
主要语言
JavaScript
星标
122k
派生
37.4k
平均合并
4 天 3 小时
30 天内合并 PR
272

描述

Version

main branch

Platform
linux/riscv64
Subsystem

FFI

What steps will reproduce the bug?

Running the parallel/test-code-cache test on a build with FFI enabled. This is spun out from the comment in https://github.com/nodejs/build/issues/4099#issuecomment-5070947806

As background FFI was first able to be enabled after https://github.com/nodejs/node/pull/63794 and superceded by the update in https://github.com/nodejs/node/pull/64040 which included the upstream fix.

How often does it reproduce? Is there a required condition?

Seems to be 100%

What is the expected behavior? Why is that the expected behavior?

Test passes.

What do you see instead?

Here are the first fiew lines of failures - the lines towards the end are replicated with different module names (i.e. it's not just internal/streams for example assert and net are included in these lines int he full log:

Path: parallel/test-code-cache
node:internal/assert/utils:146
  throw error;
  ^

AssertionError [ERR_ASSERTION]: "internal/abort_controller" should've been compiled **with** code cache
"internal/streams/end-of-stream" should've been compiled **with** code cache
"internal/streams/operators" should've been compiled **with** code cache
"internal/streams/destroy" should've been compiled **with** code cache
"internal/streams/legacy" should've been compiled **with** code cache
"internal/streams/add-abort-signal" should've been compiled **with** code cache
[...]
Additional information

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先,在启用 FFI 的 Linux/riscv64 构建上运行 parallel/test-code-cache,并将失败情况与预期的代码缓存行为进行比较。查看链接的构建 issue,以及所引用的关于 FFI 和 upstream 变更的 Node.js PR。测试通过且受影响的内部模块使用代码缓存完成编译,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
operating-systems, testing-qa
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。