Node.js consuming and reporting heap_size_limit larger than memory available via cgroups v2
Personne n'a encore pris cette issue.
- Langage dominant
- JavaScript
- Étoiles
- 122k
- Forks
- 37.4k
- Merge moyen
- 4 j 3 h
- PR mergées (30 j)
- 272
Description
Version
v26.3.1 (reproduced with latest Docker images for 20.x-26.x)
Platform
Linux dfcddcdef896 6.10.14-linuxkit #1 SMP Fri Nov 29 17:22:03 UTC 2024 aarch64 Linux
Linux 4013555a9d85 6.10.14-linuxkit #1 SMP Fri Nov 29 17:22:03 UTC 2024 aarch64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
I noticed strange discrepancy between the memory limits set for node.js containers and the actual values I get for heap_size_limit and total_available_size. I suspected these are the values used for V8 memory management, but I might be wrong.
I would like to get clarity on which values to observe, what to expect, and how to set safe limits so that garbage collection surely works. Most likely the problem is still on our side - just wanted to clear my doubts.
Steps to reproduce:
- Start a Node.js container with
docker run -it -m 256m node:26-bookworm /bin/sh - Within the container, check the memory given for the container
cat /sys/fs/cgroup/memory.max->268435456(=256 * 1024 * 1024) - Start node.js process, examine the heap size
node -e "console.log(v8.getHeapStatistics().heap_size_limit)"->274726912(=262 * 1024 * 1024)
How often does it reproduce? Is there a required condition?
Always (the OOM kills and out of memory errors vary, but we get them on daily basis).
What is the expected behavior? Why is that the expected behavior?
The heap size limit should always be smaller than the limit set for the container and reflect the total memory available for V8.
What do you see instead?
The heap size limit is reported higher than the memory limit set for the container.
Additional information
It seems heap_size_limit and total_available_size are computed by some kind of step function, with 274726912 maybe being some kind of lower bound (see below). I am unsure what are the exact memory boundaries V8 would get; and if this stepwise behavior can explain our OOM kills and/or memory allocation failures (V8 killed in garbage collecting phase). We generally would like to keep our Node.js container nimble and well below gigabyte, as we do not need much (e.g. we have containers where we never expect >128Mb being allocated and can still get OOM kills with 256 or larger limits).
The following steps show the behavior with altering memory limits:
for mem in 96 128 256 384 449 512 768 1024 1286 1536; do
docker run --rm -it -m "${mem}m" node:26-bookworm \
/usr/local/bin/node -e 'console.log(v8.getHeapStatistics().heap_size_limit)'
done
274726912
274726912
274726912
281018368
281018368
281018368
427819008
562036736
724566016
855638016
for mem in 96 128 256 384 449 512 768 1024 1286 1536; do
docker run --rm -it -m "${mem}m" node:26-bookworm \
/usr/local/bin/node -e 'console.log(v8.getHeapStatistics().total_available_size)'
done
272045872
272045848
272045872
278337312
278337328
278337328
425137968
559355696
721884968
852956976
I repeated the same with the latest Docker images for v26, v24, v22 and v20 branch, and similar results (not the exact same heap size limit but always higher than available) repeats for all of them. The problem suspectedly has always existed? For reference, cat /sys/fs/cgroup/memory.high reports as max. The same problem repeats in Kubernetes environment as well, but I used Docker setup here for the sake of easy repetition.
As for background context, these occasional out of memory errors have haunted us for almost two years already. Previously we suspected it was due to old libuv cgroups handling and later due pointer compression problems. Until recently the problem manifested itself as V8 killing itself due to heap allocation failures when doing garbage collection; and now more recently as OOM kills by Kubernetes. Now that no known issues with libuv cgroups or pointer compression exist, we wanted to see what the metrics reveal. We have tried the usual tricks of limiting old and new space sizes, but to our understanding, now that sizing by cgroups limits should work, this is no longer best practice.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par reproduire le problème avec la commande Docker fournie, puis comparez /sys/fs/cgroup/memory.max à heap_size_limit et total_available_size de V8 pour chacune des limites de mémoire listées. Suivez la gestion des cgroups v2 par Node.js et V8 afin de déterminer si les limites signalées sont intentionnelles ou dangereuses. Le travail est terminé lorsque la relation attendue est établie et que le problème dispose soit d’un correctif confirmé, soit d’une documentation d’utilisation.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- docker, javascript, linux, node.js
- Domaine
- backend, infrastructure, operating-systems, performance
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100