nodejs / nodejs/node

quic: when staying inside callback

Open
#64,422 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

quic
Dominant language
JavaScript
Stars
122k
Forks
37.3k
Avg merge
4d 2h
Merged PRs (30d)
283

Description

I am again debugging.

I just shot myself in the found,
as the client code in ondatagram stayed forever in the ngtcp2 callback scope and prevented sending data out (SendPendingData blocks it).

I wonder if it is a design problem, as people can stay in js code side of a ngtcp2 callback forever and are interfering with SendPendingData.
Here, I could mitigate it (it was actually sending data from js side and closing), but may be it is an design issue.

@jasnell @pimterry
Your opinions?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the ondatagram path and its interaction with the ngtcp2 callback scope and SendPendingData. The issue does not name files or tests, and completion criteria are not defined; first establish whether callback execution can block sending and what design change, if any, is expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
backend, networking
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.