[Test Runner] `run()` ignores `testNamePatterns` / `testSkipPatterns` when `isolation: 'none'
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 122k
- Forks
- 37.3k
- Ø Merge
- 4 T. 2 Std.
- Gemergte PRs (30 T.)
- 283
Beschreibung
Version
Latest v26.5.0, but also v24 and v22
Platform
Linux
Subsystem
No response
What steps will reproduce the bug?
How to reproduce
Create these two files in the same folder (no dependencies):
a.test.mjs
import { test } from "node:test";
test("keep_alpha", () => {});
test("drop_beta", () => {});
repro.mjs
import { run } from "node:test";
const files = ["./a.test.mjs"];
// Run the same name filter and return the names of the tests that actually ran.
async function main(isolation) {
const names = [];
for await (const e of run({ files, isolation, testNamePatterns: ["keep"] })) {
if (e.type === "test:pass" || e.type === "test:fail")
names.push(e.data.name);
}
return names.sort();
}
console.log("process:", await main("process")); // expect only keep_alpha
console.log("none: ", await main("none")); // expect only keep_alpha
process.exit(0);
Command (run from that folder):
node repro.mjs
Expected result:
process: [ 'keep_alpha' ]
none: [ 'keep_alpha' ]
Actual result:
process: [ 'keep_alpha' ] <- correct: filter applied
none: [ 'drop_beta', 'keep_alpha' ] <- BUG: filter ignored, drop_beta ran
The same filter works as a CLI flag under isolation: none
Command (run from that folder):
node --test --experimental-test-isolation=none --test-name-pattern=keep a.test.mjs
Expected result: only keep_alpha runs — drop_beta is correctly filtered out even though isolation is none:
✔ keep_alpha
ℹ tests 1
ℹ pass 1
ℹ skipped 0
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
testNamePatterns in run method should work also when isolation is set to none, not only when it is set to process
What do you see instead?
The testNamePatterns is NOT applied
Additional information
TL;DR
node:test's programmatic runnerrun()can filter tests by name withtestNamePatterns(only run matching) andtestSkipPatterns(skip matching).- Those two options do nothing when you pass
isolation: 'none'. Every test runs, filter or not. - With the default
isolation: 'process', the exact same options work fine. Only'none'is broken.
Why this is a bug, not intended behavior
- The docs for
run()describetestNamePatternsandtestSkipPatternsplainly, with no "doesn't work under isolation" note. - The same options table explicitly says
execArgv,argv, andinspectPorthave "No effect ifisolationis'none'." — but says nothing like that for the two pattern options. - So the docs promise these filters work everywhere. Under
'none', they don't.
Extra clue: the runtime can do this under 'none'
- The same filtering works under
'none'when requested as a startup flag (--test-name-pattern/--test-skip-pattern) instead of arun()option — see the Run it section below for the exact commands. - So the filtering machinery works under
'none'; only therun()option path ignores it. - The flag must be present when the process starts. Pushing it onto
process.execArgvat runtime does nothing.
NOTE
This seems like a duplicate of https://github.com/nodejs/node/issues/57399, but this issue has not been fixed, apparently.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, repro.mjs mit a.test.mjs auszuführen, und vergleiche run({ isolation: 'process' }) mit run({ isolation: 'none' }). Verfolge anschließend den Pfad der node:test-Option run() für testNamePatterns und testSkipPatterns, und füge eine Regressionstestabdeckung hinzu, die zeigt, dass beide Filter unter 'none' funktionieren, während das erwartete Verhalten der Prozessisolierung erhalten bleibt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, node.js
- Bereich
- testing-qa
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 55/100