nodejs / nodejs/node

quic: session.peerCertificate behaves differently than for http2

未关闭
#63,673 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

quic
主要语言
JavaScript
星标
122k
派生
37.3k
平均合并
4 天 2 小时
30 天内合并 PR
283

描述

I am currently implementing a custom certificate verifier.
So I wait for the sesssion.opened promise to be fullfilled, and try to check the peerCertificate.
It is an X509Certificate {} object.
I wanted to check the fingerprint256 property. For quic it is a function, for http2 it was a property (supposedly a getter).

The current doc says:

The peer's certificate as an object with properties such as subject, issuer, valid_from, valid_to, fingerprint, etc. Returns undefined if the session is destroyed or the peer did not present a certificate.

So I think the intention is that it is also a property for quic, but it is not.

Also the docu for X509Certificate says:

x509.fingerprint256#
Added in: v15.6.0
Type:
The SHA-256 fingerprint of this certificate.

Though I can see easily what differs between these implementations.
(Of course not a big deal).

@jasnell is this really an issue?

Probably this applies to other properties as well.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 QUIC 和 HTTP/2 的 session.peerCertificate 入口点开始,比较 X509Certificate.fingerprint256 的公开方式。检查相关的 X509Certificate 文档和其他对端证书属性,然后验证预期的访问方式在各协议之间是否一致。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
networking
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。