clock_time_get rejects valid WASI pointer arguments >= 0x80000000(2G)
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.4k
- 平均合并
- 4 天 3 小时
- 30 天内合并 PR
- 272
描述
Version
v24.14.1
Platform
Darwin XQ4PWYXX93 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:55 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T6031 arm64
Subsystem
wasi
What steps will reproduce the bug?
Run this with node repro.mjs(or run node reproduce.mjs in
https://github.com/hardfist/node-wasi-2gb-bug and this is the cause of Rspack CI failure https://github.com/web-infra-dev/rspack/actions/runs/24226483089/job/70729993137?pr=13655#step:13:104
import { WASI } from 'node:wasi';
const wasm = Buffer.from(
'AGFzbQEAAAABDwNgA39+fwF/YAABf2AAAAIpARZ3YXNpX3NuYXBzaG90X3ByZXZpZXcxDmNsb2NrX3RpbWVfZ2V0AAADBQQBAQECBQUBAIGAAgdHBQZtZW1vcnkCAA50ZXN0X2Nsb2NrX2xvdwABDnRlc3RfY2xvY2tfbWlkAAIPdGVzdF9jbG9ja19oaWdoAAMGX3N0YXJ0AAQKMwQMAEEAQsCEPUEAEAALEABBAELAhD1B8P///wcQAAsQAEEAQsCEPUGAgICAeBAACwIACw==',
'base64',
);
const wasi = new WASI({ version: 'preview1' });
const module = await WebAssembly.compile(wasm);
const instance = await WebAssembly.instantiate(module, {
wasi_snapshot_preview1: wasi.wasiImport,
});
try {
wasi.start(instance);
} catch {}
for (const [label, fn] of [
['0x00000000', () => instance.exports.test_clock_low()],
['0x7FFFFFF0', () => instance.exports.test_clock_mid()],
['0x80000000', () => instance.exports.test_clock_high()],
]) {
const errno = fn();
console.log(`${label}: errno=${errno}`);
}
This embeds a tiny WASM module that:
- imports
wasi_snapshot_preview1.clock_time_get - allocates
32769pages of memory (2GB + 64KB) - calls
clock_time_getwith result pointers0x00000000,0x7FFFFFF0, and0x80000000
How often does it reproduce? Is there a required condition?
It reproduces every time for me on v24.14.1 when the WASI function receives an i32 argument with the high bit set, such as pointer 0x80000000, and the module has enough linear memory for that offset. The repro needs about 2GB of free RAM because the module allocates 32769 pages.
What is the expected behavior? Why is that the expected behavior?
All three calls should succeed:
0x00000000: errno=0
0x7FFFFFF0: errno=0
0x80000000: errno=0
0x80000000 is a valid in-bounds offset for a 32769-page memory, and WASI pointer parameters are 32-bit offsets. Node should accept the full 32-bit bit-pattern range for these arguments and then rely on the existing memory bounds checks to reject only truly out-of-bounds accesses.
What do you see instead?
The third call returns EINVAL (28) even though the pointer is within bounds:
0x00000000: errno=0
0x7FFFFFF0: errno=0
0x80000000: errno=28
Additional information
I traced this to the WASI slow callback path in src/node_wasi.cc.
CheckType<uint32_t>() currently does:
template <>
bool CheckType<uint32_t>(Local<Value> value) {
return value->IsUint32();
}
But when Wasm passes i32.const 0x80000000, V8 appears to surface that value to the JS-facing slow callback as the Number -2147483648. That fails IsUint32(), so SlowCallback() returns UVWASI_EINVAL before the syscall implementation runs.
ConvertType<uint32_t>() in the same file already does:
template <>
uint32_t ConvertType(Local<Value> value) {
return value.As<Uint32>()->Value();
}
So this looks like a validation mismatch rather than a conversion or bounds-checking issue. If I am reading the code correctly, CheckType<uint32_t>() probably needs to accept the signed JS representation that Wasm i32 values can take when the high bit is set, or otherwise validate these parameters in a way that is not sensitive to JS signedness.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 src/node_wasi.cc 开始,重点关注 CheckType<uint32_t>()、ConvertType<uint32_t>() 以及 issue 中描述的慢速 callback 路径。运行提供的 WebAssembly repro,并比较三个指针值的行为;当使用 0x80000000 的边界内调用返回 errno 0,同时真正无效的指针仍被拒绝时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- cpp, javascript, nodejs, wasm
- 领域
- backend, operating-systems
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 68/100