nodejs / nodejs/node

[DNS] add AD Flag support for DNSSEC to allow DANE usage

Offen
#57,159 7 Kommentare 6 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

feature request
Vorherrschende Sprache
JavaScript
Sterne
122k
Forks
37.3k
Ø Merge
4 T. 2 Std.
Gemergte PRs (30 T.)
283

Beschreibung

What is the problem this feature will solve?

With ef91595e2fc1f96b7c8eb51bfcc1408a5adaa4a9 in PR https://github.com/nodejs/node/pull/52983 related to issue https://github.com/nodejs/node/issues/39569 you added support for TLSA resource records via dns.resolve .
This was done with the intention to support DANE.
However, to correctly make use of DANE, the records need to be DNSSEC validated.

Currently there is no possibility to validate DNSSEC via the given API.

As example, the following code (currently a nightly build)

dns.resolveTlsa("_443._tcp.fedoraproject.org", (error, result) => {
	console.log(result)
})

generates the following response

[
  {
    certUsage: 3,
    selector: 1,
    match: 1,
    data: ArrayBuffer {
      [Uint8Contents]: <09 ca 10 dd 09 f1 24 a2 26 3a a8 cc 49 12 fd a8 59 2f 40 cc ab 90 b6 10 ae 84 01 01 a9 1a eb c0>,
      byteLength: 32
    }
  }
]

Thus, as next step for the DANE implementation, this feature request aims to add information to above response of dns.resolve, about if the records have been validated by the resolver.
This allows to use technology relying on DNSSEC, such as TLSA records for DANE.

What is the feature you are proposing to solve the problem?

As DNSSEC does not protect the path between client and resolver by design, we can make use of the AD bit: RFC 6840 Section 5.7 and RFC 6840 Section 5.8

According to above mentioned RFC6840, the AD bit should be set in the query to indicate that node is going to honor the AD bit in the response. Then, the AD bit in the reply should be propagated to the returned contents of dns.resolve

If this request is included we can get to the next step of checking TLSA records within TLS certificate verification.

What alternatives have you considered?

In https://github.com/nodejs/node/issues/39569 @bradh352 mentioned the DO bit (RFC 6840 Section 5.6) and RFC 3225 Section 3, however as I read it, the setting the DO bit indicates that the client can understand DNSSEC related records. Thus, the resolver is going to attach RRSIG, etc. for validation on the client side.
In contrast, the DO bit should be set to 0 to indicate that node is unprepared to handle DNSSEC RR.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginnen Sie bei Node.js' dns.resolveTlsa API und dem in RFC 6840, Abschnitt 5.7 und 5.8, beschriebenen Resolver-Verhalten. Verfolgen Sie, wie das AD-Bit gesendet wird und wie die Antwort offengelegt wird, definieren Sie anschließend die zurückgegebenen Validierungsinformationen und überprüfen Sie sie mit DNSSEC-gestützten TLSA-Abfragen; im Issue werden keine Quelldateien oder Tests genannt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
javascript, node.js
Bereich
api, networking
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.