stream: handling invalid stream arguments in `stream... | nodejs/node

Personne n'a encore pris cette issue.

A few "what goes where"-related inconsistencies with stream.pipeline(). Validation of stream objects is very hit-and-miss:

Passing this:	as this:	should do this:	and does this:
Non-readable Node stream	source	Should be rejected.	:x: Passes validation. Gets passed to `Duplex.from()`, resulting in a write-only Duplex. The pipeline will never receive any data.
	transform	Should be rejected.	:heavy_check_mark: Fails validation.
	destination	Should be accepted.	:heavy_check_mark: Passes validation.
Non-writable Node stream	source	Should be accepted.	:heavy_check_mark: Passes validation.
	transform	Should be rejected.	:x: Passes validation. Fails asynchronously at runtime: when the previous stream in the pipeline emits data, raises a TypeError due to attempting to call missing Writable methods.
	destination	Should be rejected.	:x: Same as above.
`ReadableStream`	source	Should be accepted.	:heavy_check_mark: Passes validation.
	transform	Should be rejected.	:heavy_check_mark: Fails validation.
	destination	Should be rejected.	:x: Passes validation. Fails asynchronously at runtime: raises a TypeError due to attempting to call the missing `getWriter()` method.
`TransformStream`	source	Undocumented, but should be accepted.	:heavy_check_mark: Passes validation.
	transform	Should be accepted.	:heavy_check_mark: Passes validation.
	destination	Undocumented, but should be accepted.	:heavy_check_mark: Passes validation.
`WritableStream`	source	Should be rejected.	:x: Passes validation. Gets passed to `Duplex.from()`, resulting in a write-only Duplex. The pipeline will never receive any data.
	transform	Should be rejected.	:heavy_check_mark: Fails validation.
	destination	Should be accepted.	:heavy_check_mark: Passes validation.

These should probably be validated consistently.

Other observations:

The docs should specify that TransformStreams are valid source and destination streams, as well as valid return values.
The transform validation error message doesn't specify which parameter failed validation, which is a pain in terms of debugging. Its counterparts in stream.compose() pass the parameter name to the error constructor as streams[n], which would be a fairly straightforward improvement.

Commencez par les chemins de validation liés dans lib/internal/streams/pipeline.js, en particulier par la gestion de source, transform et destination autour des lignes 306-308, 376 et 391-395. Comparez les noms de paramètres utilisés par stream.compose() et consultez la documentation associée sur les streams. C’est terminé lorsque les arguments invalides sont rejetés de manière cohérente, que les erreurs de validation identifient le paramètre en échec et que la prise en charge de TransformStream est documentée comme décrit.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

stream: handling invalid stream arguments in `stream.pipeline()`

Description

Guide de contribution

Par où commencer

Piste de recherche

Évaluation