Cannot set up `cluster.schedulingPolicy` in ESM
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.4k
- 平均合并
- 4 天 3 小时
- 30 天内合并 PR
- 272
描述
Version
v18.17.1
Platform
Linux xxx 6.2.0-26-generic #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Jul 13 16:27:29 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
cluster
What steps will reproduce the bug?
Run the following code in Node.js:
import * as cluster from 'cluster'
if (cluster.isPrimary) {
process.env.NODE_CLUSTER_SCHED_POLICY = 'none'
console.log(`process.env.NODE_CLUSTER_SCHED_POLICY: ${process.env.NODE_CLUSTER_SCHED_POLICY}`)
for (let index = 0; index < 2; index++) {
cluster.fork()
setTimeout(() => console.log(`cluster.schedulingPolicy: ${cluster.schedulingPolicy}`), 1000)
}
} else {
setTimeout(() => null, 1000)
}
cluster-error.txt
Attached as cluster-error.txt. You will see that it prints the following:
$ node cluster-error.js
process.env.NODE_CLUSTER_SCHED_POLICY: 'none'
cluster.schedulingPolicy: 2
cluster.schedulingPolicy: 2
So the env variable NODE_CLUSTER_SCHED_POLICY has no effect, cluster.schedulingPolicy has the value 2 which is the default cluster.SCHED_RR. However running it with the env variable from the console works as expected:
$ NODE_CLUSTER_SCHED_POLICY='none' node cluster-error.js
process.env.NODE_CLUSTER_SCHED_POLICY: none
cluster.schedulingPolicy: 1
cluster.schedulingPolicy: 1
I cannot set the cluster.schedulingPolicy as per the docs: cluster.schedulingPolicy = cluster.SCHED_NONE since the cluster module is imported:
import * as cluster from 'cluster'
cluster.schedulingPolicy = cluster.SCHED_NONE
so I get a TypeError:
cluster.schedulingPolicy = cluster.SCHED_NONE
^
TypeError: Cannot assign to read only property 'schedulingPolicy' of object '[object Module]'
at file:///home/alex/projects/loadtest/cluster-error.js:2:26
at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
How often does it reproduce? Is there a required condition?
With the attached code it works (as in doesn't work) always.
What is the expected behavior? Why is that the expected behavior?
I expect to see the same output as with the env variable NODE_CLUSTER_SCHED_POLICY='none', i.e. the cluster.schedulingPolicy is set to 1 cluster.SCHED_NONE:
$ node cluster-error.js
process.env.NODE_CLUSTER_SCHED_POLICY: none
cluster.schedulingPolicy: 1
cluster.schedulingPolicy: 1
(Fake output.)
What do you see instead?
Instead I see cluster.schedulingPolicy has the default value of 2 cluster.SCHED_RR:
$ node cluster-error.js
process.env.NODE_CLUSTER_SCHED_POLICY: none
cluster.schedulingPolicy: 2
cluster.schedulingPolicy: 2
Additional information
I am the author of the loadtest package and I am converting it to multi-core. I really see a big difference of more than 30% when running the test server in the default round-robin mode and in the none mode I want to set:
cluster.SCHED_RR: 9600 rps.cluster.SCHED_NONE: 12700 rps.
It is true that load on processors is a bit more uneven in none, but that doesn't seem to matter much. I want my lightning fast speed! ⚡
Besides, I think that the documentation should be updated because the recommended way of setting cluster.schedulingPolicy does not work. I would think that the best solution is to have a setting in cluster.settings that can be set with cluster.setupPrimary([settings]). As suggested by @bnoordhuis in this hopeful comment.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
复现 ESM 示例,并结合 cluster.schedulingPolicy、cluster.settings 和 cluster.setupPrimary 的文档阅读 lib/internal/cluster/primary.js。跟踪策略的初始化方式,并确定受支持的 ESM 配置路径;当报告的 ESM 情况得到处理且文档准确描述如何设置调度策略时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, node.js
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100