Missing import trace from error stack when loading a module throws an error
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 122k
- Forks
- 37.3k
- Merge medio
- 4 d 2 h
- PR fusionados (30 d)
- 283
Descripción
Version
v16.16.0
Platform
Linux 5.4.0-139-generic #156-Ubuntu SM x86_64 GNU/Linux
Subsystem
modules
What steps will reproduce the bug?
Consider:
// foo.mjs
import './bar.mjs';
// bar.mjs
throw new Error('bar failed');
Run node foo.mjs.
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
The stack trace from the error should include a reference to foo.mjs line 1 showing where bar was imported from.
What do you see instead?
file:///.../bar.mjs:1
throw new Error('bar failed');
^
Error: bar failed
at file:///.../bar.mjs:1:7
at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
at async loadESM (node:internal/process/esm_loader:88:5)
at async handleMainPromise (node:internal/modules/run_main:61:12)
Note that the stack trace does not mention foo anywhere. This is not helpful, especially if the error is specifically about how and when bar is imported. For example, it might be a singleton and you're mistakenly creating a duplicate by loading it from both import and require, or it might need something else to be set up on the global first and you're loading it in the wrong order.
The above stack is from node 16. Node 18 produces a shorter but similarly lacking stack:
file:///.../bar.mjs:1
throw new Error('bar failed');
^
Error: bar failed
at file:///.../bar.mjs:1:7
at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
Additional information
I am aware that import() and top-level await complicates this, since modules may be effectively loading in parallel (asynchronously behind the scenes). However, it is absolutely essential that this information is made available somehow.
If the output ends up being a list of all modules trying to load the offending module then great, as long as this list is in the order the imports were encountered then that should allow debugging this kind of thing.
At the moment when this occurs it's simply impossible to debug. Since import gets hoisted by the language you can't even add console.log statements around the place to trace what's happening like you can with require. Literally the only option to debug this is to comment out all the imports and re-enable one-by-one (recursively) until you locate the problem. And in practice this inevitably breaks something else, so it's completely unworkable.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza reproduciendo el problema con los módulos foo.mjs y bar.mjs usando node foo.mjs; después, inspecciona el subsistema de módulos implicado en la carga de ESM. Rastrea cómo se propagan los errores a través de la ruta de importación y carga de módulos. Se considera terminado cuando la información de la pila resultante identifica la línea 1 de foo.mjs, teniendo en cuenta los casos de importación asíncrona descritos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- backend
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100