performance.timerify(fn) behave inconsistently for sync/async functions

Version

master branch

Platform

All

Subsystem

perf_hooks

What steps will reproduce the bug?

function f1() { throw new Error() }
async function f2() { throw new Error() }
let h1 = perf_hooks.createHistogram()
let h2 = perf_hooks.createHistogram()
let g1 = perf_hooks.performance.timerify(f1, {histogram: h1})
let g2 = perf_hooks.performance.timerify(f2, {histogram: h2})
g1()
await g2()
h1.count === h2.count // expect true, actual false

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Timerified functions should behave consistently for whether trigger histogram.record.

What do you see instead?

Currently, normal function would not trigger histogram.record if throw; but async function (or any function which return promise) would.

Additional information

Currently, the code is like if (typeof result?.finally === 'function') return result.finally(...). It should use result.then instead, so the behavior will consistent with non-thenable result. Even we want to always trigger histogram.record, we should not use finally because thenable is only require to have then method, not finally method.

从 perf_hooks performance.timerify 入口开始，使用直方图复现所提供的 sync 和 async 示例。检查如何处理返回的 promises 和抛出的错误；完成标准是：timerified sync 函数和返回 promises 的函数具有一致的直方图记录行为，包括 thenables。