nodejs / nodejs/node-core-utils
Allow `request-ci` on the collaborator's PR without restriction of at least 1 approval
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
IIRC collaborators are able to manually trigger CI through Jenkins without needing 1 approval on the PR, maybe it makes sense for the collaborators to use request-ci label on their own or other collaborators's PR without at least 1 approval restriction.
https://github.com/nodejs/node-core-utils/blob/a68af4b7744e8416bfc0f062570688b67d5e10dc/lib/pr_checker.js#L560 just an idea - could we check either the PR author is a current collaborator?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/pr_checker.js around line 560 and trace the approval restriction used by the request-ci label. Check how collaborator status and pull request authorship are represented, then verify the relevant CI-label checks. Done means an eligible collaborator can use request-ci on their own or another collaborator's pull request without requiring one approval.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authorization, ci-cd
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 56/100