nodejs / nodejs/node-core-utils
Error message from `git-node v8 backport` is less helpful than in node-core-utils@3.4.0
未关闭
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 314
- 派生
- 137
- 平均合并
- 2 天 8 小时
- 30 天内合并 PR
- 24
描述
Attempted to backport a commit that doesn't exist yet.
With node-core-utils@3.4.0:
$ npx --package=node-core-utils@3.4.0 -- git-node v8 backport df5724c11697b4fbe803adcb5a51020dea2d923f
Need to install the following packages:
node-core-utils@3.4.0
Ok to proceed? (y) y
npm WARN deprecated node-core-utils@3.4.0: This package has been renamed to @node-core/utils
(node:1406084) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
✔ Update local V8 clone
⠦ V8 commit backport
fatal: ambiguous argument 'df5724c11697b4fbe803adcb5a51020dea2d923f
^..df5724c11697b4fbe803adcb5a51020dea2d923f
': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument 'df5724c11697b4fbe803adcb5a51020dea2d923f
': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
$
With @node-core/utils@5.0.1:
$ npx --package=@node-core/utils@latest -- git-node v8 backport df5724c11697b4fbe803adcb5a51020dea2d923f
Need to install the following packages:
@node-core/utils@5.0.1
Ok to proceed? (y) y
✔ Update local V8 clone
❯ V8 commit backport
✔ Get current V8 version
✔ Generate patches
❯ Apply and commit patches to deps/v8
❯ Commit df5724c11697
✔ Apply patch
✔ Increment embedder version number
✖ Cannot read properties of undefined (reading 'replace')
✖ Cannot read properties of undefined (reading 'replace')
$
The error from the older version is a lot more indicative of what the actual problem is.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先,使用报告中显示的不存在的提交复现 git-node v8 backport 命令,并比较 node-core-utils@3.4.0 和 @node-core/utils@5.0.1 的输出。跟踪 backport 入口点及其错误处理;完成的标准是,缺失的提交会产生具体且有帮助的错误,而不是 Cannot read properties of undefined (reading 'replace')。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- git, javascript, node.js
- 领域
- cli, developer-experience
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100