nodejs / nodejs/node-core-utils
Error message from `git-node v8 backport` is less helpful than in node-core-utils@3.4.0
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
Attempted to backport a commit that doesn't exist yet.
With node-core-utils@3.4.0:
$ npx --package=node-core-utils@3.4.0 -- git-node v8 backport df5724c11697b4fbe803adcb5a51020dea2d923f
Need to install the following packages:
node-core-utils@3.4.0
Ok to proceed? (y) y
npm WARN deprecated node-core-utils@3.4.0: This package has been renamed to @node-core/utils
(node:1406084) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
✔ Update local V8 clone
⠦ V8 commit backport
fatal: ambiguous argument 'df5724c11697b4fbe803adcb5a51020dea2d923f
^..df5724c11697b4fbe803adcb5a51020dea2d923f
': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument 'df5724c11697b4fbe803adcb5a51020dea2d923f
': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
$
With @node-core/utils@5.0.1:
$ npx --package=@node-core/utils@latest -- git-node v8 backport df5724c11697b4fbe803adcb5a51020dea2d923f
Need to install the following packages:
@node-core/utils@5.0.1
Ok to proceed? (y) y
✔ Update local V8 clone
❯ V8 commit backport
✔ Get current V8 version
✔ Generate patches
❯ Apply and commit patches to deps/v8
❯ Commit df5724c11697
✔ Apply patch
✔ Increment embedder version number
✖ Cannot read properties of undefined (reading 'replace')
✖ Cannot read properties of undefined (reading 'replace')
$
The error from the older version is a lot more indicative of what the actual problem is.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the git-node v8 backport command with the nonexistent commit shown in the report, comparing the output from node-core-utils@3.4.0 and @node-core/utils@5.0.1. Trace the backport entry point and its error handling; done means the missing commit produces a specific, helpful error instead of Cannot read properties of undefined (reading 'replace').
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, javascript, node.js
- Domain
- cli, developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100