nodejs / nodejs/node-core-utils

Force push does not invalidate existing approved reviews

Open
#677 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
314
Forks
137
Avg merge
2d 8h
Merged PRs (30d)
24

Description

If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now approved reviews count as valid ones, and might lead to unwanted code to be merged to main.

Example https://github.com/nodejs/node/pull/46904

➜  node git:(main) ✗ git node metadata 46904
✔  Done loading data for nodejs/node/pull/46904
----------------------------------- PR info ------------------------------------
Title      url: use private properties for brand check (#46904)
Author     Yagiz Nizipli <yagiz@nizipli.com> (@anonrig)
Branch     anonrig:url-context -> nodejs:main
Labels     semver-major, performance, whatwg-url, esm, author ready, worker, needs-ci
Commits    1
 - url: use private properties for brand check
Committers 1
 - Yagiz Nizipli <yagiz@nizipli.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46904
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 01 Mar 2023 21:28:43 GMT
   ✔  Approvals: 3
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46904#pullrequestreview-1320667498
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/46904#pullrequestreview-1320668469
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46904#pullrequestreview-1321281126
   ✖  This PR needs to wait 21 more hours to land
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2023-03-02T23:13:10Z: https://ci.nodejs.org/job/node-test-pull-request/50175/
✔  Build data downloaded
   ✖  Last Jenkins CI still running

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source file, test, or entry point. Start by locating the review and force-push handling in node-core-utils and reproduce the nodejs/node#46904 scenario; done means an approval no longer counts after the reviewed branch is force-pushed, with coverage for that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.