nodejs / nodejs/node-core-utils
fail positive on github action fails.
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
Commit Queue failed
- Loading data for nodejs/node/pull/45573 ✔ Done loading data for nodejs/node/pull/45573 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick 2ada52cffbff (#45573) Author Michaël Zasso (@targos) Branch targos:fix-45171 -> nodejs:main Labels build, v8 engine, needs-ci Commits 1 - deps: V8: cherry-pick 2ada52cffbff Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/45573 Fixes: https://github.com/nodejs/node/issues/45171 Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45573 Fixes: https://github.com/nodejs/node/issues/45171 Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - deps: V8: cherry-pick 2ada52cffbff ℹ This PR was created on Tue, 22 Nov 2022 08:21:45 GMT ✔ Approvals: 4 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45573#pullrequestreview-1189584648 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45573#pullrequestreview-1190006137 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45573#pullrequestreview-1190051320 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45573#pullrequestreview-1191762773 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-11-23T14:48:53Z: https://ci.nodejs.org/job/node-test-pull-request/48124/ - Querying data for job/node-test-pull-request/48124/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3538908052
Originally posted by @nodejs-github-bot in https://github.com/nodejs/node/issues/45573#issuecomment-1326111158
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked GitHub Actions run and the git node land output, comparing the reported GitHub CI failure with the successful Jenkins CI result. Done means the false-positive condition is reproduced, its source is identified, and a regression check demonstrates the correct status.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, javascript
- Domain
- ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100