nodejs / nodejs/node-core-utils
Set exit code when commands fail
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
If I run git node land on a new machine with nothing configured, I'll get the instructions to set required variables, and then the process will exit with status code 0. In order for us to be able to use ncu on a Commit Queue, it needs to return the appropriate status codes when something goes wrong, otherwise automation won't work.
(I didn't check which other failures will exit with 0, but all failures should set the exit code to a non-zero code)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing git node land on a new machine with the required variables unset, then trace how the failure exits. Review the ncu command paths that report errors; done means failures return non-zero status codes so Commit Queue automation can detect them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100