nodejs / nodejs/node-core-utils

git node land simplifications

Open
#425 5 comments 1 reaction 1 assignee View on GitHub

@mmarchini is already working on this.

Since Aug 12, 2020.

enhancement git-node
Dominant language
JavaScript
Stars
314
Forks
137
Avg merge
2d 8h
Merged PRs (30d)
24

Description

It should be possible to anticipate the next command. For example in case a rebase is needed due to multiple commits. In such case, it would be nice to already execute the command that is currently printed to the terminal:

There are 3 commits in the PR
Please run the following commands to complete landing

$ git rebase origin/master -i -x "git node land --amend"
$ git node land --continue

It would be good to already run git rebase origin/master -i -x "git node land --amend". Even git node land --continue should be possible to run automatically as soon as that's done.

Removing the temporary files should also be done by default. A user might opt out by a config flag instead?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.