`update.sh` updates all versions for non-matching version input
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Dockerfile
- Sterne
- 8.6k
- Forks
- 2k
- Ø Merge
- 10 Std. 19 Min.
- Gemergte PRs (30 T.)
- 16
Beschreibung
Environment
- Platform: Ubuntu 24.04.4 LTS
- Docker Version: N/A
- Node.js Version: 24.14.1
- Image Tag: N/A
Expected Behavior
If the update.sh script is run using a MAJOR_VERSION that is not set up, such as 23 (EOL) or 26 (not yet released), the script should fail with an error message.
Current Behavior
The script acts as though no MAJOR_VERSION was specified and updates all available versions.
Possible Solution
Steps to Reproduce
Execute:
./update.sh -s 26
Additional Information
Logs
$ ./update.sh -s 26
Updating version 20...
Updating version 22...
Updating version 24...
Updating version 25...
20/bookworm-slim/Dockerfile is already up to date!
20/bookworm/Dockerfile is already up to date!
20/bullseye-slim/Dockerfile is already up to date!
20/bullseye/Dockerfile is already up to date!
20/trixie-slim/Dockerfile is already up to date!
20/trixie/Dockerfile is already up to date!
22/trixie/Dockerfile is already up to date!
22/bookworm/Dockerfile is already up to date!
22/trixie-slim/Dockerfile is already up to date!
22/bookworm-slim/Dockerfile is already up to date!
22/bullseye/Dockerfile is already up to date!
22/bullseye-slim/Dockerfile is already up to date!
24/bullseye-slim/Dockerfile is already up to date!
24/bookworm-slim/Dockerfile is already up to date!
24/bookworm/Dockerfile is already up to date!
25/bullseye/Dockerfile is already up to date!
25/bookworm/Dockerfile is already up to date!
24/bullseye/Dockerfile is already up to date!
24/trixie-slim/Dockerfile is already up to date!
24/trixie/Dockerfile is already up to date!
25/bookworm-slim/Dockerfile is already up to date!
25/trixie/Dockerfile is already up to date!
25/bullseye-slim/Dockerfile is already up to date!
25/trixie-slim/Dockerfile is already up to date!
20/alpine3.22/Dockerfile is already up to date!
22/alpine3.22/Dockerfile is already up to date!
22/alpine3.23/Dockerfile is already up to date!
20/alpine3.23/Dockerfile is already up to date!
25/alpine3.23/Dockerfile is already up to date!
24/alpine3.22/Dockerfile is already up to date!
24/alpine3.23/Dockerfile is already up to date!
25/alpine3.22/Dockerfile is already up to date!
Done!
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Lies zunächst update.sh und konzentriere dich darauf, wie das Argument -s MAJOR_VERSION geparst und mit den verfügbaren Versionen abgeglichen wird. Führe ./update.sh -s 26 aus, um das aktuelle Verhalten zu reproduzieren, und überprüfe anschließend, dass nicht unterstützte Versionen wie 23 oder 26 mit einem Fehler abbrechen, während unterstützte Versionen weiterhin normal aktualisiert werden.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- docker, shell
- Bereich
- build-system, devops
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Ruhig
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 64/100