`update.sh` updates all versions for non-matching version input
Open
Beginner friendly
Nobody has claimed this yet.
build process
- Dominant language
- Dockerfile
- Stars
- 8.6k
- Forks
- 2k
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 16
Description
Environment
- Platform: Ubuntu 24.04.4 LTS
- Docker Version: N/A
- Node.js Version: 24.14.1
- Image Tag: N/A
Expected Behavior
If the update.sh script is run using a MAJOR_VERSION that is not set up, such as 23 (EOL) or 26 (not yet released), the script should fail with an error message.
Current Behavior
The script acts as though no MAJOR_VERSION was specified and updates all available versions.
Possible Solution
Steps to Reproduce
Execute:
./update.sh -s 26
Additional Information
Logs
$ ./update.sh -s 26
Updating version 20...
Updating version 22...
Updating version 24...
Updating version 25...
20/bookworm-slim/Dockerfile is already up to date!
20/bookworm/Dockerfile is already up to date!
20/bullseye-slim/Dockerfile is already up to date!
20/bullseye/Dockerfile is already up to date!
20/trixie-slim/Dockerfile is already up to date!
20/trixie/Dockerfile is already up to date!
22/trixie/Dockerfile is already up to date!
22/bookworm/Dockerfile is already up to date!
22/trixie-slim/Dockerfile is already up to date!
22/bookworm-slim/Dockerfile is already up to date!
22/bullseye/Dockerfile is already up to date!
22/bullseye-slim/Dockerfile is already up to date!
24/bullseye-slim/Dockerfile is already up to date!
24/bookworm-slim/Dockerfile is already up to date!
24/bookworm/Dockerfile is already up to date!
25/bullseye/Dockerfile is already up to date!
25/bookworm/Dockerfile is already up to date!
24/bullseye/Dockerfile is already up to date!
24/trixie-slim/Dockerfile is already up to date!
24/trixie/Dockerfile is already up to date!
25/bookworm-slim/Dockerfile is already up to date!
25/trixie/Dockerfile is already up to date!
25/bullseye-slim/Dockerfile is already up to date!
25/trixie-slim/Dockerfile is already up to date!
20/alpine3.22/Dockerfile is already up to date!
22/alpine3.22/Dockerfile is already up to date!
22/alpine3.23/Dockerfile is already up to date!
20/alpine3.23/Dockerfile is already up to date!
25/alpine3.23/Dockerfile is already up to date!
24/alpine3.22/Dockerfile is already up to date!
24/alpine3.23/Dockerfile is already up to date!
25/alpine3.22/Dockerfile is already up to date!
Done!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading update.sh, focusing on how the -s MAJOR_VERSION argument is parsed and matched against available versions. Run ./update.sh -s 26 to reproduce the current behavior, then verify that unsupported versions such as 23 or 26 fail with an error while supported versions continue updating normally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell
- Domain
- build-system, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 64/100