nodeSolidServer / nodeSolidServer/node-solid-server
Lookup in Have I Been Pwned? database
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
This came up in https://github.com/solid/node-solid-server/pull/893#discussion_r230898095
Basically, the check in /lib/requests/create-account-request.js#L134 could be extended by looking the email up in Troy Hunt's database. There are packages to do this.
Some measures were already taken in https://github.com/solid/node-solid-server/pull/859 it seems.
If you would want to go fancy, you could look at WebAuthn API :-D
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/requests/create-account-request.js around line 134, then read the discussion in pull request 893 and the measures from pull request 859. Review the available npm packages for Have I Been Pwned lookups and determine the account-creation behavior that should result from a breach match. Done means the agreed email lookup is integrated into this check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100