nodeSolidServer / nodeSolidServer/node-solid-server
Needed fix for corsProxy (server operators must read)
未关闭
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 1.8k
- 派生
- 308
- PR 合并指标
- 30 天内没有已合并 PR
描述
Action required
If you are an NSS server operator, please check that your settings use the default "corsProxy": false.
If you have a public facing server with "corsProxy": true, please change it to "corsProxy": false until the suggested fix below is deployed.
Fix
The CORS proxy needs to be changed as follows:
- If no
Originfield present in the HTTP request, respond with a400or similar. - If the
Originvalue in the request is not the server's configured domain (podhost.example) or a direct subdomain thereof (alice.podhost.example), respond with400or similar. - If, after satistying the above two conditions, the response received from the downstream server does not indicate an RDF content type in its headers (such as Turtle, HTML, etc.), respond with
400.- In particular, images, videos, PDFs etc. must result in a
400. - The connection to the downstream server can and should be closed prematurely if the content type is not RDF.
- In particular, images, videos, PDFs etc. must result in a
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先定位 corsProxy 的实现及其请求处理测试;该 issue 未指明任何文件或测试。验证缺少 Origin 值或 Origin 值未获授权时的行为,以及下游响应不包含 RDF 内容类型时的行为。完成的标准是这些情况返回 400 或类似结果,同时允许的 RDF 响应继续正常工作。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, node.js
- 领域
- api, backend, security
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 30/100