nodeSolidServer / nodeSolidServer/node-solid-server

Phantom Websocket Pub Notification (cross-pod notification bug)

Open
#1,663 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

I am currently looking into notifications from the inbox using WebSockets over at uvdsl/solid-inbox-watcher.
(It seems that https://github.com/solid/node-solid-server/issues/933 could be closed?)

However, we ran into an odd thing:
Alice (aka. uvdsl, left hand side) and Bob (aka. ik1533, right hand side) both have their own pod on the same NSS.
When watching Alice's inbox, Alice receives a update notification via wss, when Bob's inbox is updated.
image

The PUB message Alice receives only contains "correct" data, i.e. the endpoint she subscribed to. But that resource wasn't updated...

MessageEvent {
isTrusted: true, 
data: 'pub https://uvdsl.solid.aifb.kit.edu/inbox/', 
origin: 'wss://uvdsl.solid.aifb.kit.edu', lastEventId: '', 
source: null, …}
isTrusted: true
bubbles: false
cancelBubble: false
cancelable: false
composed: false
currentTarget: WebSocket {url: 'wss://uvdsl.solid.aifb.kit.edu/inbox/', 
readyState: 1, bufferedAmount: 0, onerror: null, onopen: ƒ, …}
data: "pub https://uvdsl.solid.aifb.kit.edu/inbox/"
defaultPrevented: false
eventPhase: 0
lastEventId: ""
origin: "wss://uvdsl.solid.aifb.kit.edu"
path: []
ports: []
returnValue: true
source: null
srcElement: WebSocket {url: 'wss://uvdsl.solid.aifb.kit.edu/inbox/', readyState: 1, bufferedAmount: 0, onerror: null, onopen: ƒ, …}
target: WebSocket {url: 'wss://uvdsl.solid.aifb.kit.edu/inbox/', readyState: 1, bufferedAmount: 0, onerror: null, onopen: ƒ, …}
timeStamp: 38368.69999999972
type: "message"
userActivation: null
[[Prototype]]: MessageEvent

Other examples can be found at the corresponding issue in my app's repo: https://github.com/uvdsl/solid-inbox-watcher/issues/6

We tested it on solidweb.org and on another NSS 5.6.16
Do you have any idea as to why this happens?
Cheers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the cross-pod notification in uvdsl/solid-inbox-watcher, especially the scenario described in its issue 6, using the reported solidweb.org or NSS 5.6.16 environments. Compare the subscription endpoint with the pod that was updated; done means an inbox watcher receives a notification only when its subscribed resource changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.