nodeSolidServer / nodeSolidServer/node-solid-server
Test for trialing slashes in value for 'issuer' from '/.well-known/openid-configuration' responses
還沒有人認領這個 Issue。
- 主要語言
- JavaScript
- 星號
- 1.8k
- 分支
- 308
- PR 合併指標
- 30 天內沒有已合併 PR
描述
Basically our ESS Brokers are advertising themselves (in their /.well-known/openid-configuration responses) as issuers with a trailing slash, e.g. for https://broker.pod.inrupt.com/.well-known/openid-configuration:
{
"introspection_endpoint": "https://broker.pod.inrupt.com/introspect",
"scopes_supported": [
"openid",
"offline_access",
"webid"
],
"issuer": "https://broker.pod.inrupt.com/",
:
Note the trailing slash on the issuer URL (which is technically (slightly!) more correct than having the URL without the trailing slash).
So it seems NSS might be blindly taking that issuer value, and appending the string literal /.well-known/openid-configuration to it, without first checking if the issuer value has a trailing slash or not. If the URL constructed has two slashes, then the server responds with it’s standard HTML ‘Page Not Found’ response, which results in the ‘invalid json response…’ error.
If this is correct, then the fix in NSS should be simply checking for a trailing slash before appending /.well-known/openid-configuration.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
首先找出根據 OpenID 設定回應中傳回的 issuer 建立 /.well-known/openid-configuration URL 的程式碼。為帶有和不帶結尾斜線的 issuer 值新增涵蓋範圍,並確認兩者都會產生只有一個斜線的有效 URL,而不是無效的 JSON 回應。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript
- 領域
- authentication
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100