nodeSolidServer / nodeSolidServer/node-solid-server
Server exception not caught is lock file is not writable
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
Mon, 27 Jan 2020 22:26:29 GMT solid:get GET -- Error: undefined EACCES: permission denied, mkdir '/Library/WebServer/Documents/profile/card$.ttl.lock'
(node:1964) UnhandledPromiseRejectionWarning: TypeError: releaseLock is not a function
at Promise (/devel/github.com/solid/node-solid-server/lib/lock.js:25:13)
at <anonymous>
(node:1964) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 105274)
Mon, 27 Jan 2020 22:26:30 GMT solid:get GET -- Error: undefined EACCES: permission denied, mkdir '/Library/WebServer/Documents/timbl/Public/Archive/linkeddata/chat/2019/08/23/chat.ttl.lock'
(node:1964) UnhandledPromiseRejectionWarning: TypeError: releaseLock is not a function
at Promise (/devel/github.com/solid/node-solid-server/lib/lock.js:25:13)
at <anonymous>
(node:1964) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 105275)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/lock.js around line 25 and reproduce the EACCES failure when the lock file cannot be created. Trace how the rejected operation reaches the GET handler and verify that the server no longer emits an unhandled promise rejection for this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100