nodeSolidServer / nodeSolidServer/node-solid-server
:error in .acl causes all requests to error
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
I might be wrong about this, but I think :error in an .acl should cause an error for only the group it refers to. However, if it is present in a .acl it will cause every request to return 500.
To reproduce enter /test/resources/accounts-acl/tim.localhost/group/test-folder/.acl and uncomment
#:errors
# a acl:Authorization;
# acl:accessTo <some-other-file.txt>;
# acl:agentGroup <group-listing-error.ttl#folks>;
# acl:mode acl:Read, acl:Write.
Then run NODE_TLS_REJECT_UNAUTHORIZED=0 mocha -g Group
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting /test/resources/accounts-acl/tim.localhost/group/test-folder/.acl and uncomment the shown :errors block. Run NODE_TLS_REJECT_UNAUTHORIZED=0 mocha -g Group to reproduce the failure. Done means the ACL error affects only the referenced group and does not make every request return HTTP 500.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100